-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAC costing documentation into template dedicated file #1375
GAC costing documentation into template dedicated file #1375
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1375 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 339 339
Lines 35890 35890
=======================================
Hits 33682 33682
Misses 2208 2208 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only suggestion would be to replace instances of USD\_2020
with what I added in the comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
CI failures are unrelated and most likely due to #1158. I've restarted the failed job which should result in this PR getting automerged once it passes. |
Fixes/Resolves:
GAC costing documentation for #1360
Mostly lateral changes from unit model documentation to costing model documentation files with minor wording changes
Summary/Motivation:
Cost documentation for all unit models
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: