Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAC costing documentation into template dedicated file #1375

Merged
merged 11 commits into from
May 11, 2024

Conversation

hunterbarber
Copy link
Contributor

@hunterbarber hunterbarber commented May 2, 2024

Fixes/Resolves:

GAC costing documentation for #1360
Mostly lateral changes from unit model documentation to costing model documentation files with minor wording changes

Summary/Motivation:

Cost documentation for all unit models

Changes proposed in this PR:

  • Move costing documentation from GAC unit model doc to new cost model documentation generated from the template

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@hunterbarber hunterbarber self-assigned this May 2, 2024
@hunterbarber hunterbarber mentioned this pull request May 2, 2024
28 tasks
@hunterbarber hunterbarber added the 1.0 Hard requirement for the 1.0 release label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (38735ec) to head (b3aa409).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1375   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         339      339           
  Lines       35890    35890           
=======================================
  Hits        33682    33682           
  Misses       2208     2208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hunterbarber hunterbarber marked this pull request as ready for review May 8, 2024 14:11
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label May 9, 2024
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only suggestion would be to replace instances of USD\_2020 with what I added in the comment below.

docs/technical_reference/costing/gac.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@savannahsakhai savannahsakhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) May 10, 2024 18:38
@lbianchi-lbl
Copy link
Contributor

CI failures are unrelated and most likely due to #1158. I've restarted the failed job which should result in this PR getting automerged once it passes.

@lbianchi-lbl lbianchi-lbl merged commit 64e61f1 into watertap-org:main May 11, 2024
24 checks passed
@hunterbarber hunterbarber deleted the gac_costing_docs branch May 24, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Hard requirement for the 1.0 release Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants