Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: INFRA-478 support for external redis, default off #228

Merged
merged 5 commits into from
Feb 19, 2025
+33 −2
Merged

feat: INFRA-478 support for external redis, default off #228

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c1d7be
fix wandb value for gcp redis
j7m4 Feb 19, 2025
6d66326
fix wandb value for gcp redis, againˆ
j7m4 Feb 19, 2025
44be4d8
Merge branch 'main' into j7m4/infra-491-fix-core-managed-redis
j7m4 Feb 19, 2025
c22efa5
corrected externalized "use_external_redis" threaded from core
j7m4 Feb 19, 2025
7b27b58
terraform-docs: automated action
github-actions[bot] Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,16 @@ module "wandb" {
ttlInSeconds = 604800
caCertPath = "/etc/ssl/certs/redis_ca.pem"
}
} : var.create_redis ? {
password = module.redis[0].auth_string
host = module.redis[0].host
port = module.redis[0].port
caCert = module.redis[0].ca_cert
params = {
tls = true
ttlInSeconds = 604800
caCertPath = "/etc/ssl/certs/server_ca.pem"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems duplicated

} : {
password = ""
host = ""
Expand Down
Loading