Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: INFRA-478 support for external redis, default off #228

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

j7m4
Copy link
Contributor

@j7m4 j7m4 commented Feb 19, 2025

No description provided.

@j7m4 j7m4 requested a review from a team as a code owner February 19, 2025 18:31
Copy link

linear bot commented Feb 19, 2025

@j7m4 j7m4 marked this pull request as draft February 19, 2025 18:31
Copy link

coderabbitai bot commented Feb 19, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between 1be1600 and 7b27b58.

📒 Files selected for processing (3)
  • README.md (2 hunks)
  • main.tf (1 hunks)
  • variables.tf (1 hunks)
 _______________________________________
< For a good time, call 1-800-COD-RABT. >
 ---------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@j7m4 j7m4 changed the title feat: INFRA-491 support for external redis, default off feat: INFRA-478 support for external redis, default off Feb 19, 2025
Copy link

linear bot commented Feb 19, 2025

@j7m4 j7m4 marked this pull request as ready for review February 19, 2025 20:35
tls = true
ttlInSeconds = 604800
caCertPath = "/etc/ssl/certs/server_ca.pem"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems duplicated

@j7m4 j7m4 merged commit 25a3daf into main Feb 19, 2025
2 of 3 checks passed
@j7m4 j7m4 deleted the j7m4/infra-491-fix-core-managed-redis branch February 19, 2025 21:07
jsbroks pushed a commit that referenced this pull request Feb 19, 2025
## [9.4.0](v9.3.4...v9.4.0) (2025-02-19)

### Features

* INFRA-478 support for external redis, default off ([#228](#228)) ([25a3daf](25a3daf))
@jsbroks
Copy link
Member

jsbroks commented Feb 19, 2025

This PR is included in version 9.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants