Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to http tracing #346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: switch to http tracing #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.26.0
version: 0.26.1
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
8 changes: 4 additions & 4 deletions charts/operator-wandb/charts/otel/charts/agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ configMap:

resources:
requests:
cpu: 200m
memory: 200Mi
cpu: 300m
memory: 400Mi
limits:
cpu: 500m
memory: 500Mi
cpu: 600m
memory: 1Gi

serviceAccount:
create: true
Expand Down
4 changes: 2 additions & 2 deletions charts/operator-wandb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ global:
# defaults to the otel-daemonset service
host: ""
# grpc default is 4317, http default is 4318
port: 4317
port: 4318
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this will break if they are not on a very recent version of the server image, I'm hesitant to make the change here and we should instead make the change here https://deploy.wandb.ai/v2/admin/channels/9205b19d-9103-4ef6-88e3-4d7a6eda61a7 when we are sure that the server version with the code to support this is deployed fleet wide

# grpc, http
proto: "grpc"
proto: "http"

clickhouse:
install: false
Expand Down
Loading