-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch to http tracing #346
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis update makes several adjustments to the Helm chart for the WandB operator. The chart version was incremented in the main Chart.yaml file. Resource allocations in the nested agent values file have been increased for both CPU and memory, and the configuration for the tracing service in the values file has been updated to use a different port and protocol. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -81,9 +81,9 @@ global: | |||
# defaults to the otel-daemonset service | |||
host: "" | |||
# grpc default is 4317, http default is 4318 | |||
port: 4317 | |||
port: 4318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will break if they are not on a very recent version of the server image, I'm hesitant to make the change here and we should instead make the change here https://deploy.wandb.ai/v2/admin/channels/9205b19d-9103-4ef6-88e3-4d7a6eda61a7 when we are sure that the server version with the code to support this is deployed fleet wide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will break if they are not on a very recent version of the server image, I'm hesitant to make the change here and we should instead make the change here https://deploy.wandb.ai/v2/admin/channels/9205b19d-9103-4ef6-88e3-4d7a6eda61a7 when we are sure that the server version with the code to support this is deployed fleet wide
@danielpanzella that makes sense. We roll out every release fleet-wide, right? If so I can just wait for the next release.
Yup, should be next week I believe. |
Summary by CodeRabbit