Clarify line cue setting specification. #399
Conversation
|
@dwsinger review required |
| alignment">start</a>, <a lt="WebVTT cue line center alignment">center</a>, or <a lt="WebVTT cue line | ||
| end alignment">end</a> of the cue box, depending on the <a>WebVTT cue line alignment</a> value - <a | ||
| lt="WebVTT cue line start alignment">start</a> by default. The offset can be given either as a | ||
| percentage of the video dimension or as a line number. Line numbers are based on the size of the |
There was a problem hiding this comment.
This is the size in the block progression direction, i.e. the vertical height for horizontal cues, right?
There was a problem hiding this comment.
Thanks, I think the bit I was focusing on here was "percentage of the video dimension" which seems vague, since it's a two dimensional thing, and in general not square. Suggestion would be to qualify it by saying something like "percentage of the relevant writing-mode dependent video dimension"
There was a problem hiding this comment.
@nigelmegitt please see PR #420
| lt="WebVTT cue line start alignment">start</a> by default. The offset can be given either as a | ||
| percentage of the video dimension or as a line number. Line numbers are based on the size of the | ||
| first line of the cue. Positive line numbers count from the start of the video viewport (the first | ||
| line is numbered 0), negative line numbers from the end of the viewport (the last line is numbered |
There was a problem hiding this comment.
Is is true that start == (top or left) and end == (bottom or right)? Or are those terms writing mode dependent, i.e. end could be the left in rtl?
There was a problem hiding this comment.
I'll quote from the spec, which answers your question:
A line alignment
An alignment for the cue box’s line, one of:
Start alignment
The cue box’s top side (for horizontal cues), left side (for vertical growing right), or right side (for vertical growing left) is aligned at the line.
Center alignment
The cue box is centered at the line.
End alignment
The cue box’s bottom side (for horizontal cues), right side (for vertical growing right), or left side (for vertical growing left) is aligned at the line.
By default, the line alignment is set to start.
The line alignment is separate from the text alignment — right-to-left vs. left-to-right cue text does not affect the line alignment.
There was a problem hiding this comment.
Thanks, I thought so. I'm not sure why I was asking now, probably I was worried about the meaning of "start" being clear, but it is well defined. This looks fine to me now.
Closes #382