Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide Review Comment 2017: line cue setting direction #382

Closed
nigelmegitt opened this issue Sep 27, 2017 · 11 comments
Closed

Wide Review Comment 2017: line cue setting direction #382

nigelmegitt opened this issue Sep 27, 2017 · 11 comments

Comments

@nigelmegitt
Copy link
Contributor

Copy/paste from https://lists.w3.org/Archives/Public/public-tt/2017Sep/0080.html - raising as an issue for tracking/disposition purposes.

(Context is section 4.4 "WebVTT cue settings" -> the "WebVTT line cue setting")

looking at that line cue setting, it "configures the offset of the cue box from the video viewport's edge in the direction opposite to the writing direction". I think that means "orthogonal to the writing direction" but it could be interpreted as the negative of the writing direction, i.e. If the writing direction is top-to-bottom then does this mean left-to-right or bottom-to-top?

Then the WebVTT position cue setting "configures the indent position of the cue box in the direction orthogonal to the WebVTT line cue setting". Why doesn't it simply say "in the writing direction"?

@silviapfeiffer
Copy link
Member

The writing direction is specified here: https://www.w3.org/TR/webvtt1/#webvtt-cue-writing-direction and it is either horizontal or vertical. The example provided should have clarified this, it says: For horizontal cues, this is the vertical offset from the top of the video viewport.

I'll change "opposite" to "orthogonal" and add some clarifying text.

@nigelmegitt
Copy link
Contributor Author

Thanks, that looks good for the first part of the issue - there remains the question at the end.

@silviapfeiffer
Copy link
Member

Resolution at TPAC: Silvia & Nigel to work out the last sentence

@silviapfeiffer
Copy link
Member

About the last sentence:

The definition of "position" says the following:
The position defines the indent of the cue box in the direction defined by the writing direction.
https://w3c.github.io/webvtt/#webvtt-cue-position

So, what you are requesting is already defined as such.

The later explanation of "position" at
https://w3c.github.io/webvtt/#webvtt-position-cue-setting
just explains the relationship between "position" and "line" cue setting. It provides information in that given context.

I think this is ok as is.

@silviapfeiffer
Copy link
Member

@nigelmegitt could you review and say if you're ok with the patch as landed in #399 ?

@nigelmegitt
Copy link
Contributor Author

#399 generated a couple of further questions for me. Plus it does not address the point about the language in the note under WebVTT position cue setting which still weirdly says "configures the indent position of the cue box in the direction orthogonal to the WebVTT line cue setting" rather than "configures the indent position of the cue box in the writing direction".

@nigelmegitt nigelmegitt reopened this Nov 23, 2017
@silviapfeiffer
Copy link
Member

That would be a repetition because that was already stated before in the definition of "position" (see #382 (comment)).

That note is not providing a definition - rather it is clarifying a different relationship. It's deliberately not repeating the definition.

@nigelmegitt
Copy link
Contributor Author

OK, I still think it's weird, but I can live with it.

@silviapfeiffer
Copy link
Member

Could you please choose an appropriate label (commenter-agreed or commenter-agreed-partial)? We can then close this issue. Thanks.

@dwsinger
Copy link

dwsinger commented Dec 8, 2017

I chose for @nigelmegitt but he can change if he likes.

@nigelmegitt
Copy link
Contributor Author

Seems like partial agreement is a better fit for this situation.

@dwsinger dwsinger added the WR label Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants