Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus appearance enclosed #2284

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Mar 28, 2022

An attempt to see how this looks using "encloses" in place of "encompasses"

Added some visual examples which are NOT intended to be permanent. They are not svgs, and need to be replaced (and modified). Wanted to give an idea of how the images might look in context.

@alastc please feel free to alter as you like.


Preview | Diff

This is an attempt to see what the use of "encloses" does to the Understanding document. All the images are temporary (since they are poorly screen captured pngs)
@mbgower mbgower requested a review from alastc March 28, 2022 05:34
@mbgower mbgower changed the base branch from main to focus-appearance-encompass March 28, 2022 05:35
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbgower. I concur that use of encloses invokes the idea of a solid boundary sufficiently. It is a much better choice than than encompasses (or embiggen).

@mbgower mbgower mentioned this pull request Mar 28, 2022
@alastc alastc merged commit 3691c8c into focus-appearance-encompass Apr 1, 2022
@fstrr fstrr deleted the focus-appearance-enclosed branch January 13, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants