-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus-Appearance rework #2281
Focus-Appearance rework #2281
Conversation
@alastc — Please see my comment in the Google doc. I believe a rigid reading of |
Hi @bruce-usab, remember that the exception is still based on area, so any non-continuous indicators would fall through to the exception (which doesn't use Encompasses). |
@alastc — I wrote something similar in the Google doc.
I do not agree that this is good enough, since the exception is part of the SC, not the definition. On the survey, I asked: Does a UI like marching ants meets the definition for encompasses? (And I noted that I thought it did, and should.) I was scribe, and I did not accurately track your reply on the call, my apologies, The reply I heard was, With the benefit of hindsight, I wish your answer had been more along the line of: My suggestion is to move the |
Ah, I had read that as: does it pass? Ok, so this is whether the meaning of the word matches the intent. (CCing @mbgower ) The intent is to require a solid line because there is no reference to area (for simplicity), so without a solid line you could just have 4 dots around the corners and pass. So does "encompasses" mean / imply a solid line? The dictionary definitions aren't particularly mathematical. I thought it did imply continuous, but a couple of people did not which is why we added "continuously" to the definition. For what is supposed to be the simple part of the SC text, I'd rather not have two very overlapping words in the same sentence. What about swapping "encompasses" with "surrounds"? The definition of Surrounds is "a thing that forms a border or edging round an object.", which to me implies continuous. That would be:
Definition:
|
Thanks @alastc. I am more comfortable with a specialize particular meaning for I am totally behind the principle that |
@bruce-usab My concern with using “surrounds” is that it fails to address some common outliers, such as a button that changes its color. By making the definition for “encompass” include “surrounds” as well as some related but distinct terms, we manage to tackle all those edge cases while maintaining a word that has a broader meaning than “surrounds” while including it. Hope that helps |
since you've made it singular, the defined term in the anchor needs to be singular (which matches the glossary)
@mbgower That changing colour technique wouldn't pass the primary part of the SC anyway, that would fall through to the exception (and pass). Bruce's point is just about which term matches the intent best, and I'm fairly ambivalent about that (I thought they both did, but others have said that 'encompasses' wasn't quite right). |
Why wouldn't it pass the primary? I was careful with that wording and definition, and this is the first I've heard of someone not liking "encompasses". We had quite a bit of discussion about that when the text was first broad forward. Encompasses typically means all the variations in the definition. Making it "surrounds" diminishes it, to me. |
@mbgower — It is not good for an industry consensus document to use terms in ways that might be surprising. Most people would assume a dashed line can be used to encompass or surround or bound (or even circle). My larger concern is patching a quirk with our defined term by using an exception in an SC. But since How about using embiggen in the SC and glossary? I cannot think of a word that conveys that the indicator must be continuous. |
It is not used in a unique way. It is a common usage of the term. I gave an example in our email thread. As well, it is a defined term. It's not difficult to understand the way WCAG is using it. You just click on the definition term and see a pithy 8 word definition. I assume using "embiggen" is a joke? :) Otherwise, I'm not sure why you would propose replacing what you call a fancy word with a term i've never heard of which, when I looked it up, seems to have been first used on a Simpson's episode. |
If the problem here is that you're trying to make it clear a dashed line fails, might I suggest: |
I am fine with I am fine with a dashed line failing the SC. I just think that it has to be that a dashed line fails against the SC metrics, not because a dashed line cannot be used to encompass something or @mbgower — your Britannica cite is an example of I used the Merriam Webster cite for embiggen, it is a perfectly cromulent word. My point is that it, for our context, it would better to use an unusual word rather than to ascribe an unusual characteristic to a common word. OTOH the word |
I just meant that a couple of people didn't think it implied solid.
I read encompasses to mean going around something, not inside it. Also the definition includes surrounds/bounds.
and
The crux is that the first part of the SC does not include the (more complex) size metrics, so there is no differentiation between a (passing) thicker dashed line, and 4 dots on the corners. Therefore that part of the SC is not going to have the nuance to pass a dotted line. So we need a simple word/words that equates to a solid line around the component for that first part. Bruce and Gundula seem set on including that in the SC text. I can't see another single word that is better, so that would be:
|
I think that is fine. Just for clarification, it is not that I am |
"Continuously encompass" just seems awkward to me. For my money "solidly bounds, surrounds or includes the whole of" as a definition of encompasses is pretty good. |
@mbgower — "solidly bounds, surrounds or includes the whole of" is fine as a concept. It is not fine as definition for "encompasses" because only a minority of people using that word would presume "solidly". The fact that we dare not leave encompasses undefined illustrates why there is a problem. We would not be using "encompasses" with "its ordinarily accepted meaning in the sense that the context implies." See: E103.2 Undefined Terms. This is where I believe we are with the top half of the SC: When a user interface components has keyboard focus, the focus indicator:
So how about instead: When a user interface components has keyboard focus, the focus indicator:
|
First draft involving encompasses. I've also added the heading for the second of the primary considerations
This is an attempt to see what the use of "encloses" does to the Understanding document. All the images are temporary (since they are poorly screen captured pngs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR, I am still seeing encompasses
as a defined term with solidly
as a required characteristics. That detail goes above and beyond usual meaning of the wordr.
But I am also seeing definitions for focus and perimeter which I am comfortable with. So I am not confident that I looking at the most recent version.
@bruce-usab most up to date of my proposed changes are in 2284 (linked in my last comment). Note that they are cumulative, so it helps to look at 2283 first to see the progression from 2281 |
Focus appearance enclosed
incorporated the discussion points from today
updated background
minor tweaking to improve read through
minimal changes to term styling
substantial modifications of the Understanding to make the reading flow and the page narrative progressive.
Repositioned some material to improve flow. Made additional minor edits. Reviewed up to "Unusual shapes and gradients"
Updated the final exception bullets. I believe this is ready for a read through by someone else.
matched language of ACT for bounding box non-rotated/non-skewed langauge, as per @WilcoFiers request
Adding a modification to the new Focus Not Obscured SC from #2204
updated Understanding document to match normative change
Minor wordsmithing to correct typos and better align text
Changes to normative language to match changes in Understanding
resolving comments on axis
first draft at tackling perceived component
removing the now discarded focus definition
Massive update to content in an attempt to work in working examples and guidance for complex components. Will need to be revised but serves as a starting point
Changes to figure captions for consistency, as well as mild editorial tweaks and addition of image placeholders
Rewrite of adjacent contrast
Focus appearance encompass
Based on the recent meetings.
Preview the SC text and revised understanding doc.
To do: The updates to the AAA version.
Closes: #2219, #2222, #2226,
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Apr 27, 2022, 9:01 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.