Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content models w.r.t. permissible styling attributes (#1155). #1157

Merged
merged 5 commits into from
Sep 22, 2019

Conversation

skynavga
Copy link
Collaborator

@skynavga skynavga commented Sep 8, 2019

Closes #1155.

This PR is untestable for the same reasons described at #1096 (comment).

@skynavga skynavga added substantive syntax Changes document syntax. untestable Not interoperably testable. labels Sep 8, 2019
@skynavga skynavga added this to the 2ED-FPWD milestone Sep 8, 2019
@skynavga skynavga requested a review from nigelmegitt September 8, 2019 03:42
@skynavga skynavga self-assigned this Sep 8, 2019
@nigelmegitt
Copy link
Contributor

I think this is in fact testable, since it is constraining the set of styling attributes that are permitted. Therefore an invalidity test can be constructed that includes an animate or set element (or both) that targets tts:ruby, for example.

@skynavga
Copy link
Collaborator Author

skynavga commented Sep 9, 2019

@nigelmegitt yes, that is true, but only for the changes to the content models of animate and set; however, I planned to add tests for that constrain (can't target non-animatable styles) in the context of #1154, which adds other language proscribing this usage without needing the change in content model to do so

@nigelmegitt
Copy link
Contributor

@skynavga okay, that would work too.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the only change that needs reviewing here is e8223bd, since this also merges in changes from #1154, this looks good to me.

@skynavga skynavga merged commit 60e8ff4 into master Sep 22, 2019
@skynavga skynavga deleted the issue-1155-styling-attributes branch September 22, 2019 01:47
@skynavga skynavga removed their assignment Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substantive syntax Changes document syntax. untestable Not interoperably testable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for styling attributes and animatable styling attributes in the content model.
2 participants