Define [animatable style]; make targeting non-animatable style an error (#1153). #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelmegitt
requested changes
Sep 5, 2019
There was a problem hiding this comment.
This pull request is going in the right direction for me; there's one minor typo, but two bigger points:
-
It doesn't address point 1 of the issue, hence the "Request changes".
-
I don't think we specify the behaviour if an
animateelement is used to continuously animate the value of an animatable style that is only discretely animatable. Should the implementation make some attempt to synthesise discrete animation times at which quantised values apply, for example? Or should that style attribute be ignored in the context of thatanimateelement?
nigelmegitt
approved these changes
Sep 5, 2019
|
As per #1157 (comment), tests to be added for this pull request. |
|
Tests at w3c/ttml2-tests#226. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1153.