Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit XML whitespace in base64 data. #1003

Closed
skynavga opened this issue Sep 20, 2018 · 4 comments · Fixed by #1131
Closed

Permit XML whitespace in base64 data. #1003

skynavga opened this issue Sep 20, 2018 · 4 comments · Fixed by #1131

Comments

@skynavga
Copy link
Collaborator

See also w3c/ttml2-tests#185 (comment).

@skynavga skynavga added this to the 2ED milestone Sep 20, 2018
@nigelmegitt
Copy link
Contributor

According to the man page for base64 there is an option to insert line breaks every n characters when base64 encoding, but I haven't had chance to check if that changes all the bytes or just chops the encoded output and inserts additional characters.

If we do allow white space we should be clear about how decoding is supposed to happen, i.e. if the processor is expected to strip all the white space before decoding, or if it is supposed to permit some specific white space to remain in the string passed to the decoder.

@skynavga
Copy link
Collaborator Author

We will simply say that non-(base64)-alphabet characters are stripped out prior to base64 decoding, as is done with MIME decoders, about which see [1].

[1] https://tools.ietf.org/html/rfc4648#section-3.3

@nigelmegitt
Copy link
Contributor

That would work for me.

@skynavga
Copy link
Collaborator Author

Marking this issue as a bug since the omission of interspersed LWSP in encoded data was an oversight.

skynavga added a commit that referenced this issue Aug 2, 2019
Ignore linear whitespace in data and chunk element #PCDATA (#1003).
@skynavga skynavga removed their assignment Aug 2, 2019
@skynavga skynavga added pr merged and removed pr open labels Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants