Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded audio gives base64 decode error. #185

Closed
nigelmegitt opened this issue Sep 20, 2018 · 1 comment
Closed

Embedded audio gives base64 decode error. #185

nigelmegitt opened this issue Sep 20, 2018 · 1 comment

Comments

@nigelmegitt
Copy link
Contributor

When base64 decoding the audio in:

  • ttml2-prstn-audio-embedding-chunked.xml and
  • ttml2-prstn-audio-embedding-sourced.xml

there's an invalid character error (input to base64 formed by creating a text file from the source data):

$ base64 -D -i chunked-source-base64.txt -o chunked-source-audio.wav
Invalid character in input stream.

I will propose a pull request that replaces the base64 encoded data with audio data that does not produce this error.

@nigelmegitt nigelmegitt self-assigned this Sep 20, 2018
nigelmegitt added a commit that referenced this issue Sep 20, 2018
Embedded audio now is a base64 encoded mp3 file with no id3 tags which says "Embedded audio" when you play it. The base64 encoding has no line breaks.

Fixes #185
@skynavga
Copy link
Contributor

skynavga commented Sep 20, 2018

Actually, it was my intention to permit normal XML whitespace characters in base64 data, which is permitted [1], and which would be ignored by decoders [2]. However, I see that RFC4648 wants the referring spec (in our case TTML2) to explicitly sanction such usage. I will add an issue (for resolution in 2e) to explicitly permit these characters within base64 data.

[1] https://tools.ietf.org/html/rfc4648#section-3.1
[2] https://tools.ietf.org/html/rfc4648#section-3.3

@skynavga skynavga changed the title Embedded audio gives base64 decode error Embedded audio gives base64 decode error. Sep 22, 2018
skynavga added a commit that referenced this issue Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants