Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Slider and Multi-Thumb Slider Design Pattern warnings #1803

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Update Slider and Multi-Thumb Slider Design Pattern warnings #1803

merged 2 commits into from
Mar 15, 2021

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Mar 4, 2021 •
edited by pr-preview bot
Loading

Fixes #1800

  • Update Slider and Multi-Thumb Slider Design Pattern warnings
  • Fix broken link to slider-color-viewer.html

Preview | Diff

@carmacleod
Update Slider and Multi-Thumb Slider Design Pattern warnings
8906646 
Fix broken link to slider-color-viewer.html
@carmacleod carmacleod mentioned this pull request Mar 5, 2021
Closed
@carmacleod carmacleod requested a review from jongund March 5, 2021 14:13
jongund
jongund requested changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carolyn,

This looks great, just one other change in line 2364 at the end of the list item, change "color picker" to "color viewer".

Thank you for getting this updated.

@carmacleod
Copy link
Contributor Author

@jongund

change "color picker" to "color viewer".

Done!

Thank you for getting this updated.

You're welcome. Thanks for the review!

@jongund jongund self-requested a review March 5, 2021 15:27
@carmacleod carmacleod requested a review from mcking65 March 9, 2021 19:51
@a11ydoer a11ydoer merged commit 0553bb5 into main Mar 15, 2021
@zcorpan zcorpan deleted the issue1800 branch May 31, 2021 12:27
@zcorpan zcorpan mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongund jongund jongund approved these changes

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update warning in slider design patterns/fix broken link
3 participants
@carmacleod @jongund @a11ydoer