-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warning in slider design patterns/fix broken link #1800
Comments
@carmacleod |
This is about the warning note in the Slider Design Pattern itself in the aria-practices.html file. Here are the 2 Design Pattern links. They both have the old note: Also, the link in the first pattern still points to slider-1.html and it needs to point to slider-color-viewer.html. I also noticed that you renamed "Horizontal Slider" to "Color Viewer Slider" in the examples/index.html (but not in aria-practices.html). You may want to change the aria-practices.html Design Pattern example links to have the new name and link. |
Here are the links to Preview Links in PRs: |
@jongund I edited my previous comment because I forgot that the top-level filename was called Note that after #1755 is merged, we will also need to update and after #1758 is merged, we will need to update |
@jongund @carmacleod @mcking65 I reviewed the change one more time. it is ready to be merged. |
#1803 PR is merged and closed. @jongund @carmacleod and @mcking65 |
The warning in the slider and multi-thumb slider design patterns needs to be updated to the latest wording from the new color slider example page.
Also, the Horizontal Slider Examples link in the slider design pattern needs to be changed from:
https://w3c.github.io/aria-practices/examples/slider/slider-1.html
to:
https://w3c.github.io/aria-practices/examples/slider/slider-color-viewer.html
and maybe change the link text to "Color Viewer Slider"?
The text was updated successfully, but these errors were encountered: