Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warning in slider design patterns/fix broken link #1800

Closed
carmacleod opened this issue Mar 3, 2021 · 6 comments · Fixed by #1803
Closed

Update warning in slider design patterns/fix broken link #1800

carmacleod opened this issue Mar 3, 2021 · 6 comments · Fixed by #1803
Assignees
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Milestone

Comments

@carmacleod
Copy link
Contributor

The warning in the slider and multi-thumb slider design patterns needs to be updated to the latest wording from the new color slider example page.

Also, the Horizontal Slider Examples link in the slider design pattern needs to be changed from:
https://w3c.github.io/aria-practices/examples/slider/slider-1.html
to:
https://w3c.github.io/aria-practices/examples/slider/slider-color-viewer.html

and maybe change the link text to "Color Viewer Slider"?

@jongund
Copy link
Contributor

jongund commented Mar 3, 2021

@carmacleod
I updated the warning message is both the thermostat and multithumb slider branches to match what is in color viewer slider.

@jongund jongund closed this as completed Mar 3, 2021
@carmacleod
Copy link
Contributor Author

carmacleod commented Mar 4, 2021

This is about the warning note in the Slider Design Pattern itself in the aria-practices.html file.
I don't see that note updated in any of the slider PRs.

Here are the 2 Design Pattern links. They both have the old note:

Also, the link in the first pattern still points to slider-1.html and it needs to point to slider-color-viewer.html.

I also noticed that you renamed "Horizontal Slider" to "Color Viewer Slider" in the examples/index.html (but not in aria-practices.html). You may want to change the aria-practices.html Design Pattern example links to have the new name and link.

@carmacleod carmacleod reopened this Mar 4, 2021
@jongund
Copy link
Contributor

jongund commented Mar 4, 2021

@carmacleod

Here are the links to Preview Links in PRs:

@carmacleod
Copy link
Contributor Author

carmacleod commented Mar 4, 2021

@jongund
I created PR #1803 to show what I mean. Please review! :)

I edited my previous comment because I forgot that the top-level filename was called aria-practices.html, and I was calling it index.html.

Note that after #1755 is merged, we will also need to update slider-2.html to slider-thermostat.html in aria-practices.html (and change "Three thermostat control sliders" to "Two thermostat control sliders"),

and after #1758 is merged, we will need to update multithumb-slider.html to slider-multithumb.html in aria-practices.html.

@a11ydoer a11ydoer assigned a11ydoer and mcking65 and unassigned mcking65 Mar 15, 2021
@a11ydoer
Copy link
Contributor

@jongund @carmacleod @mcking65 I reviewed the change one more time. it is ready to be merged.

@a11ydoer
Copy link
Contributor

#1803 PR is merged and closed. @jongund @carmacleod and @mcking65

@mcking65 mcking65 added documentation editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. labels May 24, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants