Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting admins view tracking on CandidateTestPlanRun #1343

Draft
wants to merge 2 commits into
base: includeVendorApprovalStatus
Choose a base branch
from
Draft

Supporting admins view tracking on CandidateTestPlanRun #1343

wants to merge 2 commits into from

Conversation

howard-e
Copy link
Contributor

To discuss #1328 (comment) directly. Conceptually, it would be a bit odd to include the admins tracking of the TestPlanVersions in the Candidate phase as the table name is potentially confusing.

So this PR mainly does 2 things:

  • Renames the VendorApprovalStatus table to ReviewerStatus (we can workshop this) and all relevant references.
  • Removes the vendorId as part of the composite primary key. userId and testPlanReportId remains.

@howard-e howard-e requested a review from stalgiag March 17, 2025 20:24
@howard-e howard-e changed the title Supporting admins tracking for the CandidateTestPlanRun Supporting admins view tracking on CandidateTestPlanRun Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalgiag stalgiag Awaiting requested review from stalgiag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@howard-e