feat: Include `VendorApprovalStatus` table #1328

howard-e · 2025-02-25T14:37:26Z

Address #1310

…ons.tests[].viewers[] and TestPlanReport.vendorReviewStatus

…endorApprovalStatus

…hanges' test

howard-e · 2025-03-04T22:43:24Z

#1329 should fix the build error happening here.

# Conflicts: # client/tests/e2e/snapshots/saved/_data-management.html # client/tests/e2e/snapshots/saved/_test-queue.html

stalgiag

This is a great improvement! I am especially happy about the removal of viewers. I didn't realize that this value wasn't being used to track viewed tests in normal runs as well.

I looked through the code and tested everything manually. Everything works great for the most part. I am a bit on the fence about the loss of information about reviewed tests for admins. It doesn't feel like a major problem but in the current version of the app when an admin views candidate reports they can see tests they have already looked at in the test nav. This doesn't seem too important but it does make me wander if we want that test nav to always show tests that have been viewed by the vendor reviewer since that is the most important info.

Other than that, just a few small comments inline. I'll pass back to you to address any that you think are appropriate

stalgiag · 2025-03-06T17:57:03Z

server/resolvers/TestPlanVersionOperations/updatePhaseResolver.js

@@ -295,12 +285,13 @@ const updatePhaseResolver = async (
      recommendedPhaseTargetDate: recommendedPhaseTargetDateValue,
      deprecatedAt: null
    };
-  } else if (phase === 'RECOMMENDED')
+  } else if (phase === 'RECOMMENDED') {


Wild that these were missing.

stalgiag · 2025-03-06T18:00:04Z

server/resolvers/TestPlanReportOperations/promoteVendorReviewStatusResolver.js

+      vendorId: user.vendorId || user.company?.id,
+      values: {
+        reviewStatus,
+        approvedAt: reviewStatus === 'APPROVED' ? new Date() : null


nit: does modification of this value need to be exposed outside of the service?

Not at all! Could be a useful way to quickly shift the status in a development sense but certainly not something that should remain. Good catch!

Done in 7cd4f8b

stalgiag · 2025-03-06T18:09:08Z

server/models/services/VendorApprovalStatusService.js

+      testPlanReportId,
+      userId,
+      vendorId
+    },


It might be that status sometimes applies to a plural or it might be that Ids is plural in the function name but it took a second for me to understand that this is the get single function and the below is the get all function. Maybe do a quick check to make sure all ids were passed in to prevent that confusion in the future?

I was more following the existing pattern and this seemed slightly different given a composite is used here! I've chosen to just drop the s in 317aa5c. Let me know if this works

stalgiag · 2025-03-06T18:13:16Z

server/migrations/20250217155901-createVendorApprovalStatus.js

+              )
+              .map(({ id }) => id);
+            const isApproved = testPlanReport.vendorReviewStatus === 'APPROVED';
+            const date = new Date();


Does this matter? It seems that there was no tracking of the approval date previously so I guess it is fine to use the current date but curious your thoughts

Maybe not. And it being falsified as a one-off could be explained. The trade off is if approvedAt gets surfaced in the future, some reviews won't have dates available. If we're okay with that, I could leave a note in so that detail is remembered.

stalgiag · 2025-03-06T18:20:41Z

server/migrations/20250217155901-createVendorApprovalStatus.js

+        { transaction }
+      );
+
+      await queryInterface.createTable(


I appreciate the frozen table definition

stalgiag · 2025-03-06T18:46:46Z

server/resolvers/addViewerResolver.js

+      });
+    }
+  } catch (error) {
+    // console.error('addViewerResolver.error', error);


Did you mean to leave this in? I wouldn't mind leaving uncommented error logging in

Sure can uncomment.

P.S. I think this is part of a wider need I've been coming across, especially when debugging in a deployed environment.

…yIds -> getVendorApprovalStatusById

…failling summary; Update snapshots

howard-e · 2025-03-13T05:43:24Z

... I am a bit on the fence about the loss of information about reviewed tests for admins. It doesn't feel like a major problem but in the current version of the app when an admin views candidate reports they can see tests they have already looked at in the test nav. This doesn't seem too important but it does make me wander if we want that test nav to always show tests that have been viewed by the vendor reviewer since that is the most important info.

Going through the current viewers, I realized a small amount are actually viewed by admins, which made me feel more comfortable doing away with that. But this is a question we can raise with them to see if this information is worth preserving for their needs before moving forward.

stalgiag · 2025-03-13T16:27:04Z

Going through the current viewers, I realized a small amount are actually viewed by admins, which made me feel more comfortable doing away with that. But this is a question we can raise with them to see if this information is worth preserving for their needs before moving forward.

I agree that the tiny amount of "data loss" is inconsequential here. I meant more for moving forward, it feels slightly odd to have the UI show "viewed" in the test nav temporarily and then when you navigate away and back, have it reset. I almost want it to persist info about vendor viewed tests for everyone. It really isn't a strong opinion though and I'd be happy to merge as-is and consider whether something like this makes sense in the future.

howard-e · 2025-03-13T16:37:02Z

Going through the current viewers, I realized a small amount are actually viewed by admins, which made me feel more comfortable doing away with that. But this is a question we can raise with them to see if this information is worth preserving for their needs before moving forward.

I agree that the tiny amount of "data loss" is inconsequential here. I meant more for moving forward, it feels slightly odd to have the UI show "viewed" in the test nav temporarily and then when you navigate away and back, have it reset. I almost want it to persist info about vendor viewed tests for everyone.

Okay, I understand your point on that better now! Let me take a look into that.

# Conflicts: # client/tests/e2e/snapshots/saved/_account_settings.html # client/tests/e2e/snapshots/saved/_data-management.html # server/resolvers/helpers/processCopiedReports.js

howard-e added 12 commits February 19, 2025 17:07

Include VendorApprovalStatus table and remove usages of TestPlanVersi…

dc40950

…ons.tests[].viewers[] and TestPlanReport.vendorReviewStatus

Remove vendorReviewStatus from TestPlanReport model

450c157

Stop accounting for TestPlanReport.viewers during copy process; use V…

dbb6580

…endorApprovalStatus

Fix migration

f6eaeed

Update snapshots

f4b1e73

Fix tests

1e30c6b

Dynamic ats called on Candidate Review Page

76703f4

Fix 'keeps approval status across version updates if no substantial c…

432625c

…hanges' test

Fix graphql.test.js

f8d73a3

Fix snapshots

b39ff35

Test node bump

b8a013b

Revert

c663374

howard-e requested a review from stalgiag March 6, 2025 18:42

Merge branch 'development' into includeVendorApprovalStatus

28ec782

# Conflicts: # client/tests/e2e/snapshots/saved/_data-management.html # client/tests/e2e/snapshots/saved/_test-queue.html

howard-e changed the title ~~Include VendorApprovalStatus table~~ feat: Include VendorApprovalStatus table Mar 6, 2025

stalgiag reviewed Mar 6, 2025

View reviewed changes

howard-e added 4 commits March 13, 2025 01:09

Remove need for passing 'reviewStatus' to bump vendorReviewStatus

7cd4f8b

VendorApprovalStatusService function rename: getVendorApprovalStatusB…

317aa5c

…yIds -> getVendorApprovalStatusById

Uncomment error log

b017623

Fix excluded priority assertions not properly being accounted for in …

dc3ac6d

…failling summary; Update snapshots

howard-e added 2 commits March 13, 2025 10:43

Fix tests

d5d96eb

Missing selector

3cf8930

howard-e mentioned this pull request Mar 17, 2025

Supporting admins view tracking on CandidateTestPlanRun #1343

Draft

Merge branch 'development' into includeVendorApprovalStatus

d88d16f

# Conflicts: # client/tests/e2e/snapshots/saved/_account_settings.html # client/tests/e2e/snapshots/saved/_data-management.html # server/resolvers/helpers/processCopiedReports.js

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Include `VendorApprovalStatus` table #1328

feat: Include `VendorApprovalStatus` table #1328

howard-e commented Feb 25, 2025

howard-e commented Mar 4, 2025

stalgiag left a comment

stalgiag Mar 6, 2025

stalgiag Mar 6, 2025

howard-e Mar 13, 2025

howard-e Mar 13, 2025

stalgiag Mar 6, 2025

howard-e Mar 13, 2025

stalgiag Mar 6, 2025

howard-e Mar 13, 2025

stalgiag Mar 6, 2025

stalgiag Mar 6, 2025 •

edited

Loading

howard-e Mar 13, 2025

howard-e Mar 13, 2025

howard-e commented Mar 13, 2025

stalgiag commented Mar 13, 2025

howard-e commented Mar 13, 2025

feat: Include VendorApprovalStatus table #1328

Are you sure you want to change the base?

feat: Include VendorApprovalStatus table #1328

Conversation

howard-e commented Feb 25, 2025

howard-e commented Mar 4, 2025

stalgiag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stalgiag Mar 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

howard-e commented Mar 13, 2025

stalgiag commented Mar 13, 2025

howard-e commented Mar 13, 2025

feat: Include `VendorApprovalStatus` table #1328

feat: Include `VendorApprovalStatus` table #1328

stalgiag Mar 6, 2025 •

edited

Loading