Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: T6208: fix AttributeError: 'ConfigDict' object has no attribute 'upper' (backport #3272) #3273

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 7, 2024

Change Summary

Commit b30faa4 (container: T6208: rename "cap-add" CLI node to "capability") added an AttributeError referencing an out of scope variable.

This has been fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

container

Proposed changes

How to test

run add container image busybox:stable
set container name c01 image busybox:stable
set container name c01 allow-host-networks
set container name c01 capability net-raw

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3272 done by [Mergify](https://mergify.com).

…ibute 'upper'

Commit b30faa4 (container: T6208: rename "cap-add" CLI node to "capability")
added an AttributeError referencing an out of scope variable.

This has been fixed.

(cherry picked from commit 2463bd2)
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 7, 2024 05:58
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 7, 2024
@sever-sever sever-sever merged commit be84bbd into sagitta Apr 7, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3272 branch April 7, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

2 participants