Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container: T6208: fix AttributeError: 'ConfigDict' object has no attribute 'upper' #3272

Merged
merged 1 commit into from
Apr 7, 2024
Merged

container: T6208: fix AttributeError: 'ConfigDict' object has no attribute 'upper' #3272

merged 1 commit into from
Apr 7, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 7, 2024

Change Summary

Commit b30faa4 (container: T6208: rename "cap-add" CLI node to "capability") added an AttributeError referencing an out of scope variable.

This has been fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

container

Proposed changes

How to test

run add container image busybox:stable
set container name c01 image busybox:stable
set container name c01 allow-host-networks
set container name c01 capability net-raw

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
container: T6208: fix AttributeError: 'ConfigDict' object has no attr…
2463bd2 
…ibute 'upper'

Commit b30faa4 (container: T6208: rename "cap-add" CLI node to "capability")
added an AttributeError referencing an out of scope variable.

This has been fixed.
@vyosbot vyosbot requested review from a team and dmbaturin and removed request for a team April 7, 2024 05:56
@c-po c-po merged commit 44b1a30 into vyos:current Apr 7, 2024
7 checks passed
@c-po
Copy link
Member Author

c-po commented Apr 7, 2024

@Mergifyio backport sagitta

@c-po c-po deleted the container-fix branch April 7, 2024 05:56
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 7, 2024 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 7, 2024
Merged
12 tasks
sever-sever added a commit that referenced this pull request Apr 7, 2024
@sever-sever
Merge pull request #3273 from vyos/mergify/bp/sagitta/pr-3272
be84bbd 
container: T6208: fix AttributeError: 'ConfigDict' object has no attribute 'upper' (backport #3272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c-po