Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: delete language command incompatible with single-quotes #4298

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

demiankatz
Copy link
Member

When we made the format of our language files more flexible, we neglected to update the delete command for compatibility. I discovered this while cleaning up strings in #4236. This PR fixes the problem and improves the associated unit test.

@demiankatz demiankatz added this to the 11.0 milestone Mar 15, 2025
@demiankatz demiankatz requested a review from EreMaijala March 15, 2025 11:44
@demiankatz demiankatz modified the milestones: 11.0, 10.2 Mar 15, 2025
@demiankatz demiankatz changed the base branch from dev to release-10.2 March 15, 2025 12:30
@demiankatz demiankatz changed the base branch from release-10.2 to release-10.1 March 18, 2025 10:41
@demiankatz demiankatz modified the milestones: 10.2, 10.1.3 Mar 18, 2025
@demiankatz demiankatz merged commit 56cb421 into vufind-org:release-10.1 Mar 18, 2025
6 checks passed
@demiankatz demiankatz deleted the fix-delete-command branch March 18, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants