-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VUFIND-747] Create Breadcrumbs view helper. #4236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sturkel89 -- I have resolved the conflict here and have also reviewed your latest updated templates. They all look correct, but I had a few minor stylistic comments. You can use the buttons in my comments below to apply the changes and save yourself the trouble of making the edits yourself, and then you can pull the latest down to your environment when you're ready to work on more.
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
…ade/ files, and a couple of other random files
…fy.phtml Co-authored-by: Demian Katz <demian.katz@villanova.edu>
…html Co-authored-by: Demian Katz <demian.katz@villanova.edu>
themes/bootstrap5/templates/record/storageretrievalrequest.phtml
Outdated
Show resolved
Hide resolved
All tests are now passing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the unused translations @demiankatz mentioned removed, this looks good to me!
Thanks, @EreMaijala, I cleaned up the language files and added some unit tests before merging this. |
This PR adds a view helper that uses templates to render breadcrumb trails. This makes it easier to customize and modify breadcrumbs globally, and makes breadcrumb construction more readable in individual templates.
For now, the helper manipulates
$this->layout()->breadcrumbs
for backward compatibility, but it could be modified to use its own internal string instead of the layout at some point in the future if we want to make it more self-contained.TODO