Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR does not work when node_modules is a symlink #1609

Closed
tmcdos opened this issue Jun 18, 2018 · 1 comment · Fixed by #2409
Closed

HMR does not work when node_modules is a symlink #1609

tmcdos opened this issue Jun 18, 2018 · 1 comment · Fixed by #2409
Labels
enhancement

Comments

@tmcdos
Copy link

tmcdos commented Jun 18, 2018

Version

3.0.0-rc.3

Reproduction link

https://github.com/tmcdos/vuecli/tree/master

Steps to reproduce

Create a fresh project with "vue create myproject"
Make the "node_modules" a symlink - e.g. from "d:\work\myproject\node_modules" to "e:\node_modules" (which is a RAM-disk)
Start the development server with "npm run serve"
Open the project in your favorite browser - http://localhost:8080
Try to change something in Home.vue component

What is expected?

The browser must hot-reload the changes - because it is clearly seen on the console that any change in the source code is noticed by the webpack's file watcher and the application is immediately rebuild (showing the errors, if any).

What is actually happening?

You will see the project being rebuilt in the console - however no hot-reload will happen in the browser.
WebSocket listener receives information about the new bundle name(s) - but does not issue AJAX call(s) to fetch the new code.

I am also using this approach (with a symlink for node_modules to a RAM-disk) with the old Vue-CLI 2.9.6 and it works perfectly fine.
@Akryum
Copy link
Member

Akryum commented Jun 28, 2018

Maybe this is related to webpack?

haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this issue Aug 31, 2018
@haoqunjiang
fix: set default symlinks to true
fd77fa8 
Currently in Vue CLI we set the default `symlinks` config to `false`.
This setting is counterintuitive, and inconsitent with webpack's default
configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks

The change of default `symlinks` value is introduced by vuejs@5b4df14
It is most likely a duplicate of vuejs@145492b

Since several third-party npm clients uses symlinks to speed up installation
(e.g. cnpm, pnpm...), that change breaks webpack HMR for their users.
See vuejs#1559, vuejs#2195, vuejs#2284

This commit also fixes vuejs#1609
@haoqunjiang haoqunjiang mentioned this issue Aug 31, 2018
Merged
haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this issue Aug 31, 2018
@haoqunjiang
fix: revert default symlinks setting
20730ba 
Currently in Vue CLI we set the default `symlinks` config to `false`.
This setting is counterintuitive, and inconsitent with webpack's default
configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks

The change of default `symlinks` value is introduced by vuejs@5b4df14
It is most likely a duplicate of vuejs@145492b

Since several third-party npm clients uses symlinks to speed up installation
(e.g. cnpm, pnpm...), that change breaks webpack HMR for their users.
See vuejs#1559, vuejs#2195, vuejs#2284

This commit also fixes vuejs#1609
haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this issue Sep 3, 2018
@haoqunjiang
fix: revert default symlinks setting
937204a 
Currently in Vue CLI we set the default `symlinks` config to `false`.
This setting is counterintuitive, and inconsitent with webpack's default
configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks

The change of default `symlinks` value is introduced by vuejs@5b4df14
It is most likely a duplicate of vuejs@145492b

Since several third-party npm clients uses symlinks to speed up installation
(e.g. cnpm, pnpm...), that change breaks webpack HMR for their users.
See vuejs#1559, vuejs#2195, vuejs#2284

This commit also fixes vuejs#1609
haoqunjiang added a commit to haoqunjiang/vue-cli that referenced this issue Sep 4, 2018
@haoqunjiang
fix: revert default symlinks setting
a783d20 
Currently in Vue CLI we set the default `symlinks` config to `false`.
This setting is counterintuitive, and inconsitent with webpack's default
configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks

The change of default `symlinks` value is introduced by vuejs@5b4df14
It is most likely a duplicate of vuejs@145492b

Since several third-party npm clients uses symlinks to speed up installation
(e.g. cnpm, pnpm...), that change breaks webpack HMR for their users.
See vuejs#1559, vuejs#2195, vuejs#2284

This commit also fixes vuejs#1609
haoqunjiang added a commit that referenced this issue Sep 5, 2018
@haoqunjiang
fix: revert default symlinks setting (#2409)
c9cc225 
Currently in Vue CLI we set the default `symlinks` config to `false`.
This setting is counterintuitive, and inconsistent with webpack's default
configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks

The change of default `symlinks` value is introduced by 5b4df14
It is most likely a duplicate of 145492b

Since several third-party npm clients uses symlinks to speed up installation
(e.g. cnpm, pnpm...), that change breaks webpack HMR for their users.
See #1559, #2195, #2284

This commit also fixes #1609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: revert default symlinks setting haoqunjiang/vue-cli
3 participants
@yyx990803 @Akryum @tmcdos