Skip to content

Commit

Permalink
fix: revert default symlinks setting (#2409)
Browse files Browse the repository at this point in the history
Currently in Vue CLI we set the default `symlinks` config to `false`.
This setting is counterintuitive, and inconsistent with webpack's default
configuration, per https://webpack.js.org/configuration/resolve/#resolve-symlinks

The change of default `symlinks` value is introduced by 5b4df14
It is most likely a duplicate of 145492b

Since several third-party npm clients uses symlinks to speed up installation
(e.g. cnpm, pnpm...), that change breaks webpack HMR for their users.
See #1559, #2195, #2284

This commit also fixes #1609
  • Loading branch information
haoqunjiang authored Sep 5, 2018
1 parent 8582a08 commit c9cc225
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/@vue/cli-service/lib/config/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ module.exports = (api, options) => {
.publicPath(options.baseUrl)

webpackConfig.resolve
.set('symlinks', false)
.extensions
.merge(['.js', '.jsx', '.vue', '.json'])
.end()
Expand Down

1 comment on commit c9cc225

@daetal-us
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was experiencing similar problems (node_modules is symlinked) -- they were fixed as of 3.0.2 and then after an update to v3.0.3 the problems return. Reverting to v3.0.2 resolves this issues without any changes to the codebase.

Please sign in to comment.