Fix the value of date-time input field #47
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
react/components/FormHandler.tsx
Outdated
| @@ -35,6 +36,11 @@ export const FormHandler: FC<{ | |||
| } | |||
| dispatchSubmitAction({ type: 'SET_LOADING' }) | |||
|
|
|||
| data = parseDateTimeFieldsData({ | |||
There was a problem hiding this comment.
It's not a really good practice to reassign parameters. I think you should create a new const for this.
There was a problem hiding this comment.
You're right, fixed. Thank you for the review 😃
react/logic/parseDateTimeFields.ts
Outdated
| }: ParseDateTimeParams) => { | ||
| Object.entries(properties).forEach(([propertyKey, property]) => { | ||
| if ((property as any)?.format === 'date-time' && data[propertyKey]) { | ||
| data[propertyKey] = new Date(data[propertyKey]).toISOString() |
There was a problem hiding this comment.
Same here. Could you create a new object at the beginning of the function like const parsedData = { ...data } and work with that instead of directly writing on the data?
39ef2fd to
4e7ce63
Compare
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Fix the value of the date-time input field, also bump react-hook-form-jsonschema.
This fix avoids breaking the submit when a store uses master data v2.
How to test it?
https://formtest--storecomponents.myvtex.com/
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
vtex/react-hook-form-jsonschema#38
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)