Avoid reasign properties

vtex-apps · Aug 3, 2021 · 4e7ce63 · 4e7ce63
1 parent 3d8806c
commit 4e7ce63
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/react/components/FormHandler.tsx b/react/components/FormHandler.tsx
@@ -36,23 +36,23 @@ export const FormHandler: FC<{
       }
       dispatchSubmitAction({ type: 'SET_LOADING' })
 
-      data = parseDateTimeFieldsData({
+      const parsedData = parseDateTimeFieldsData({
         data,
         properties: props.schema.properties,
       })
 
       await createDocumentMutation({
         variables: {
           dataEntity: props.formProps.entity,
-          document: { document: data },
+          document: { document: parsedData },
           schema: props.formProps.schema,
         },
       })
         .then(() => {
           dispatchSubmitAction({ type: 'SET_SUCCESS' })
         })
         .catch(e => {
-          setLastErrorFieldValues(data)
+          setLastErrorFieldValues(parsedData)
 
           if (e.graphQLErrors) {
             for (const graphqlError of e.graphQLErrors as GraphQLError[]) {

diff --git a/react/logic/parseDateTimeFields.ts b/react/logic/parseDateTimeFields.ts
@@ -7,11 +7,12 @@ export const parseDateTimeFieldsData = ({
   data,
   properties,
 }: ParseDateTimeParams) => {
+  const parsedData = { ...data }
   Object.entries(properties).forEach(([propertyKey, property]) => {
-    if ((property as any)?.format === 'date-time' && data[propertyKey]) {
-      data[propertyKey] = new Date(data[propertyKey]).toISOString()
+    if ((property as any)?.format === 'date-time' && parsedData[propertyKey]) {
+      parsedData[propertyKey] = new Date(parsedData[propertyKey]).toISOString()
     }
   })
 
-  return data
+  return parsedData
 }