Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Retrurn empty block when no has products #8

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

davipguimaraes
Copy link
Contributor

What problem is this solving?

  • Hidden title(block) when not has product similar
  • Tag <a/> without css handler and with duplicate <a/> in final code

Screenshots or example usage

  • title without products similars
    image

  • Tag <a /> without css handler exemple
    image

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented May 9, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented May 9, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@borgim
Copy link

borgim commented Aug 18, 2022

Hey VTEX, this PR is very important to solve a simple problem, but that many customers complain about.
With this PR we can reduce the development time of new stores, as we do not need to create a new component
@ivanlopezluna

@pedrovasalmeida
Copy link

Hi, VTEX.
Please, merge this PR. It's solves this annoying problem and it's very useful.

Thanks!

@ivanlopezluna

@feraraujofilho
Copy link

Any news here?

Copy link
Contributor

@eduardocesb eduardocesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@eduardocesb eduardocesb merged commit d50b234 into vtex-apps:master Jul 6, 2023
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jul 6, 2023

Your PR has been merged! App is being published. 🚀
Version 0.1.0 → 0.1.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.similar-products-variants@0.1.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@eduardocesb
Copy link
Contributor

Hi @davipguimaraes, thank you so much for the PR, and sorry for the long time to answer this.

We've just finished to deploy it, could you please let us know if this solved your problem or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants