Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFS-2226] Feat: auth delete file #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

iago1501
Copy link
Contributor

@iago1501 iago1501 commented Feb 19, 2025

Delete FIle Url now requires authentication to be performed

  • Auth clients added
  • requiresAuth directive created

Copy link

vtex-io-ci-cd bot commented Feb 19, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@iago1501 iago1501 self-assigned this Feb 19, 2025
@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 19, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iago1501 iago1501 changed the title Feat/auth delete file [SFS-2187] Feat/auth delete file Feb 19, 2025
@iago1501 iago1501 changed the title [SFS-2187] Feat/auth delete file [SFS-2187] Feat: auth delete file Feb 19, 2025
@iago1501 iago1501 added the enhancement New feature or request label Feb 19, 2025
@iago1501 iago1501 changed the title [SFS-2187] Feat: auth delete file [SFS-2226] Feat: auth delete file Feb 19, 2025
Copy link

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good considering that that fixes suggested in PR #11 will be merged/rebased to this branch

iago1501 and others added 2 commits February 28, 2025 15:54
    pick 055277d feat: auth requirement when calling deleteFile mutation
@iago1501 iago1501 force-pushed the feat/auth-delete-file branch from 055277d to e172b64 Compare February 28, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants