Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFS-2225] refactor: code refactor with updates and rebuild #11

Merged
merged 9 commits into from
Feb 27, 2025

Conversation

iago1501
Copy link
Contributor

@iago1501 iago1501 commented Feb 18, 2025

Refactoring code in order to build it again:

  • Update of node builder
  • Typescript Refactor
  • Lint issues
  • Changelog added
  • @vtex/api updated
  • Removed and renamed unused/unecessary code and imports
curl --request POST \
  --url 'http://filemanager8--storecomponents.myvtex.com/_v/public/graphql/v1?v=423423' \
  --header 'Content-Type: application/json' \
  --header 'User-Agent: insomnia/10.3.0' \
  --cookie janus_sid=6669c956-3c64-4672-8ce3-560df12ba5bc \
  --data '{"query":"{\n    getFileUrl (path: \"7a392d14-588d-4906-8f68-b10cebae3884.png\" bucket: \"images\")\n}  ","variables":{}}'

@iago1501 iago1501 added the enhancement New feature or request label Feb 18, 2025
@iago1501 iago1501 self-assigned this Feb 18, 2025
Copy link

vtex-io-ci-cd bot commented Feb 18, 2025

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 18, 2025

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iago1501 iago1501 marked this pull request as draft February 18, 2025 18:29
@iago1501 iago1501 changed the title refactor: code refactor with updates and rebuild [SFS-2187] refactor: code refactor with updates and rebuild Feb 18, 2025
@iago1501 iago1501 changed the title [SFS-2187] refactor: code refactor with updates and rebuild [SFS-2225] refactor: code refactor with updates and rebuild Feb 18, 2025
@iago1501 iago1501 marked this pull request as ready for review February 18, 2025 20:10
Copy link

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iago1501 basically the one thing that I believe might need an adjustment is the usage of ramdafunctions like pathEq, path, pick as properties of Error objects.

@iago1501 iago1501 merged commit 8872df8 into master Feb 27, 2025
4 checks passed
Copy link

vtex-io-ci-cd bot commented Feb 27, 2025

Your PR has been merged! App is being published. 🚀
Version 0.3.0 → 0.4.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.file-manager-graphql@0.4.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants