Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting #914 #937

Merged
merged 1 commit into from
May 30, 2017
Merged

Reverting #914 #937

merged 1 commit into from
May 30, 2017

Conversation

jsdevel
Copy link
Collaborator

@jsdevel jsdevel commented May 30, 2017

@coveralls
Copy link

coveralls commented May 30, 2017

Coverage Status

Coverage increased (+0.07%) to 93.266% when pulling 2f8c045 on reverting-914 into 94a8b54 on master.

@jsdevel
Copy link
Collaborator Author

jsdevel commented May 30, 2017

Just a heads up @vfrbgt, #914 broke existing behavior, so we're going to be reverting it. If you can re-apply your changes from #914 in a way that allows the latest tests from @pihvi to pass we'll happily merge them back.

@jsdevel jsdevel requested a review from herom May 30, 2017 22:36
@coveralls
Copy link

coveralls commented May 30, 2017

Coverage Status

Coverage increased (+0.02%) to 93.215% when pulling f2f05fc on reverting-914 into 94a8b54 on master.

@jsdevel jsdevel merged commit 97e0452 into master May 30, 2017
@jsdevel jsdevel deleted the reverting-914 branch May 30, 2017 22:39
@jsdevel
Copy link
Collaborator Author

jsdevel commented May 30, 2017

Published as v0.19.1 cc @herom

@herom herom mentioned this pull request May 31, 2017
@pihvi
Copy link
Contributor

pihvi commented May 31, 2017

Works now, thanks for the fast response!

Also just want to say I was a bit terrified to have to work with SOAP in my project. I wanted to try if Node.js could handle soap. And when it was just npm install soap, read the wsdl and I got a working client with all the methods eating JSON, I was just blown away and happy! It's almost better than REST ;) But anyway.. THANK YOU for node-soap!

@jsdevel
Copy link
Collaborator Author

jsdevel commented May 31, 2017

Also just want to say I was a bit terrified to have to work with SOAP in my project. I wanted to try if Node.js could handle soap. And when it was just npm install soap, read the wsdl and I got a working client with all the methods eating JSON, I was just blown away and happy! It's almost better than REST ;) But anyway.. THANK YOU for node-soap!

@herom we should start a testimonial section in the README 😆

@herom
Copy link
Contributor

herom commented Jun 1, 2017

@jsdevel yeah, with a "disclaimer" saying: "If you have to deal with SOAP - good luck" 😈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants