[FIX] [DO NOT MERGE] Possible fix #933 (regression because of introduction of new be… #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's sad about this is, that we'd have a tradeoff and introducing yet another "option" which may or may not get passed to the |
…new behaviour in vpulim#914)
|
may I ask for your opinion on this fix @jsdevel ? 😸 |
|
I don't think an option for this is good. Perhaps we should just revert #914. Do we know what releases that PR made it into? |
|
Closed due to #937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…haviour in #914)
This is very much "work in progress", so please feel free to review/comment/contribute until it's ready to merge and ready to use 😺