Add numeric tag convention support #8
Conversation
Also add a better output when tags don't match supported naming convention
lib/ra10ke.rb
Outdated
| version_tags = tags.select { |f| /^[vV]\d/.match(f) } | ||
| latest_ref = version_tags.keys.sort.last | ||
| elsif ref.match(/^\d[\.\d]*/) |
There was a problem hiding this comment.
this block is not really needed, just improve the regexp to make the [vV] part optional
There was a problem hiding this comment.
It allows to filter tags according to the convention found if the Puppetfile ref.
If for some historical reason a repo has the both naming convention, this block prevent from getting weird sort result.
It's not necessary, tell me.
There was a problem hiding this comment.
What I mean is instead of having this elsif block, to make the regexp on line 58 to something like /^([vV)]?\d/, or even better to use your improvement and have /^([vV])?\d[\.\d]*/
lib/ra10ke.rb
Outdated
| version_tags = tags.select { |f| /^[vV]\d/.match(f) } | ||
| latest_ref = version_tags.keys.sort.last | ||
| elsif ref.match(/^\d[\.\d]*/) |
There was a problem hiding this comment.
What I mean is instead of having this elsif block, to make the regexp on line 58 to something like /^([vV)]?\d/, or even better to use your improvement and have /^([vV])?\d[\.\d]*/
Also add a better output when tags don't match supported naming convention