Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numeric tags (without leading "v") #7

Closed
HerveMARTIN opened this issue Apr 26, 2017 · 3 comments
Closed

Allow numeric tags (without leading "v") #7

HerveMARTIN opened this issue Apr 26, 2017 · 3 comments

Comments

@HerveMARTIN
Copy link

As i don't find any good reason to not allow numeric tags, it would be a good thing to change this behavior.
It's sometimes difficult (or impossible) to ask third party module to change their tag naming convention...
Here is an example : https://github.com/elastic/puppet-kibana/tags

@HerveMARTIN
Copy link
Author

I understand that the naming convention must be coherent in order to sort tags, but I think if the ref doesn't match /^[vV]\d/ you could try to match the numeric only convention, no?

@HerveMARTIN
Copy link
Author

I'm not a ruby dev but I've made a PR : #8

@tampakrap
Copy link
Contributor

merged, thanks a lot for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants