Feature: dynamic shared mem moe_align_block_size_kernel #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcmoritz Can you take a look? The PR looks good to me. |
pcmoritz
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thanks, the PR looks good to me, feel free to merge @WoosukKwon !
WoosukKwon
reviewed
Mar 13, 2024
There was a problem hiding this comment.
@akhoroshev Thanks for submitting the PR! Left minor comments.
|
Also, just curious: which MoE model are you using? Is there any public model with more than 128 experts? |
This is not a public model |
|
@WoosukKwon comments taken into account |
WoosukKwon
approved these changes
Mar 15, 2024
simon-mo
added a commit
to simon-mo/vllm
that referenced
this pull request
Mar 16, 2024
…size_kernel (vllm-project#3376)" This reverts commit 78b6c48.
simon-mo
added a commit
to simon-mo/vllm
that referenced
this pull request
Mar 18, 2024
…n_block_size_kernel (vllm-project#3376)"" This reverts commit fe983cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered compilation errors related to insufficient shared memory size when I tried to increase NUM_MAX_EXPERTS to 128.
@zwd003