builder: use ANSI .rsp file under Windows #22409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsi_not_null_terminated
|
Some tests: case 1. D:\v\v\v\thirdparty\tcc\tcc.exe @C:\Users\DDT\AppData\Local\Temp\v_0\测试.tmp.c.rsp
tcc: error: file 'C:\Users\DDT\AppData\Local\Temp\v_0\娴嬭瘯.tmp.c' not foundcase 2. D:\v\v\v\thirdparty\tcc\tcc.exe @C:\Users\DDT\AppData\Local\Temp\v_0\测试.tmp.c.rsp
tcc: error: file '锘? not foundcase 3. D:\v\v\v\thirdparty\tcc\tcc.exe @C:\Users\DDT\AppData\Local\Temp\v_0\测试.tmp.c.rsp
C:/Users/DDT/AppData/Local/Temp/v_0/测试.tmp.c:526: warning: WINVER redefined
C:/Users/DDT/AppData/Local/Temp/v_0/测试.tmp.c:7009: warning: implicit declaration of function 'tcc_backtrace'
tcc: error: undefined symbol 'tcc_backtrace' |
spytheman
reviewed
Oct 4, 2024
| unsafe { vmemcpy(str_to.data, s.str, s.len) } | ||
| return str_to | ||
| } | ||
| return []u8{} // TODO: remove this, bug? |
There was a problem hiding this comment.
just return [] should be enough (and removing lines 109-111)
There was a problem hiding this comment.
(the cleanup can be done separately though - the CI has already passed a lot of the CI jobs, and I want to merge it ASAP)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nsi_not_null_terminated
As PR #22405 said, tcc will fail with non-ASCII filename under Windows 10.
So this PR try to make the .rsp file encoded in ANSI.
Also, builtin provide some new funcs help do the job UTF-8=>ANSI.