-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder: fix non-ASCII pathname under Windows #22405
Conversation
Importing Besides, the V compiler already has no problem with non ASCII pathnames under windows or anything else. What does have problem with those, on windows, is the prebuilt tcc executable that we ship in vlang/tccbin . You can verify that by just using |
As for:
That is worth doing in a private function in v.builder, that has a |
It is interesting though if only the encoding of the .rsp file has to change 🤔 . |
This is not good for me. As tcc not work with non-ASCII filename. V full version: V 0.4.8 0390c07 getwd: D:\v\v\v vroot: OK, value: D:\v\v\v Git version: git version 2.43.0.windows.1 CC version: Error: 'cc' is not recognized as an internal or external command, thirdparty/tcc status: thirdparty-windows-amd64 b425ac82 |
This PR may help solve #20743, #21502, #21718
Because Windows use CP_ACP encoding, not UTF-8. So the generated rsp file should be encoded in CP_ACP/ANSI encoding under Windows.
This PR will help users build non-ASCII filename/pathname: