New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo Site Cache Handler: disable full route cache #2785

Merged

johnnyomair merged 1 commit into main from disable-full-route-cache

Nov 20, 2024

Member

nsams commented Nov 20, 2024

Detect Full Route Cache by checking if the key starts with "/", as Full Route Cache keys are the page url (and start with /), data caches are a hash.

Motivation

We don't want to use Full Route Cache (by default) as it might be too large to fit into memory
We don't want to make pages dynamic, as that would result in cache-control: no-store response headers as well

Based on vivid-planet/comet-starter#522


          Demo Site Cache Handler: disable full route cache

fa176ce

nsams requested a review from johnnyomair

November 20, 2024 10:01

auto-assign bot assigned nsams

johnnyomair approved these changes

View reviewed changes

johnnyomair merged commit 8769949 into main

11 checks passed

johnnyomair deleted the disable-full-route-cache branch

November 20, 2024 11:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet