Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Cache Handler: disable Full Route Cache #522

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

nsams
Copy link
Member

@nsams nsams commented Nov 13, 2024

Detect Full Route Cache by checking if the key starts with "/", as Full Route Cache keys are the page url (and start with /), data caches are a hash.

Motivation

  • We don't want to use Full Route Cache (by default) as it might be too large to fit into memory
  • We don't want to make pages dynamic, as that would result in cache-control: no-store response headers as well

TODO

  • comet demo implementation

detect full-route cache by checking if the key starts with "/", as full-route-cache keys are the page url (and start with /), data caches are a hash
@johnnyomair johnnyomair changed the title Site CacheHandler: disable full-route-cache Site Cache Handler: disable Full Route Cache Nov 18, 2024
@johnnyomair johnnyomair merged commit 98160e4 into main Nov 18, 2024
4 checks passed
@johnnyomair johnnyomair deleted the disable-full-route-cache branch November 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants