Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make userService optional #1684

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Make userService optional #1684

merged 3 commits into from
Feb 19, 2024

Conversation

fraxachun
Copy link
Contributor

@fraxachun fraxachun commented Feb 11, 2024 •
edited
Loading

Allows easier migration as the userService is only needed for
the UserPermissions administration panel

@fraxachun fraxachun force-pushed the user-permission-user-service-optional branch 2 times, most recently from b7c22fb to 93be0ac Compare February 11, 2024 11:11
@fraxachun fraxachun mentioned this pull request Feb 11, 2024
Merged
@fraxachun fraxachun force-pushed the user-permission-user-service-optional branch 7 times, most recently from 22e5725 to d05c79b Compare February 15, 2024 10:17
@fraxachun
Copy link
Contributor Author

@johnnyomair @nsams This PR is ready for review now.

@fraxachun
Make userService optional
3686dc0 
Allows easier migration as the userService is only needed for
the UserPermissions administration panel
@fraxachun fraxachun force-pushed the user-permission-user-service-optional branch from d05c79b to 3686dc0 Compare February 15, 2024 10:27
nsams
nsams previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@nsams nsams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also mention that in the migration guide?

@fraxachun
Copy link
Contributor Author

you could also mention that in the migration guide?

1c4f618

@johnnyomair johnnyomair merged commit 7ea43eb into main Feb 19, 2024
10 checks passed
@johnnyomair johnnyomair deleted the user-permission-user-service-optional branch February 19, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsams nsams nsams approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

@thomasdax98 thomasdax98 Awaiting requested review from thomasdax98

Assignees

@fraxachun fraxachun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fraxachun @nsams @johnnyomair