Remove CurrentUserLoader and CurrentUserInterface #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2024
nsams
reviewed
Feb 12, 2024
I'd search thru existing v6 projects if it is used |
That won't be a problem, only one project in a dev-branch affected. |
johnnyomair
reviewed
Feb 13, 2024
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
johnnyomair
approved these changes
Feb 14, 2024
nsams
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the basis for #1684
Removes the unnecessary layer between auth-strategies and the CurrentUser-object. Since the UserPermissionsModule is mandatory by any means it is allowed for it to provide the one and only CurrentUser-DTO.
This change is mainly internal facing. However, it could be breaking if a Comet 6 web uses a custom CurrentUserLoader (which was discouraged but possible) or is messing around with the auth-strategies.
Update: the latest commits which remove the CurrentUserInterface require to replace it in the application (mainly when using @GetCurrentUser(). Should we allow this potentially breaking change in 6.x or export a CurrentUserInterface for legacy reasons?