COM-85: Docs, changelog & types for new theming method #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
789c595 to
f26bf62
Compare
f26bf62 to
5370ce7
Compare
|
nvm I guess that only works if you target main |
thomasdax98
reviewed
Nov 16, 2023
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Dax <thomas.dax@vivid-planet.com>
johnnyomair
reviewed
Nov 22, 2023
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
docs/docs/internal-development/create-admin-components-with-theme-support.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
This is to have a single object that contains all values that influence a component's styling. Similar to how MUI does it internally.
johnnyomair
previously approved these changes
Nov 22, 2023
thomasdax98
reviewed
Nov 22, 2023
johnnyomair
approved these changes
Nov 23, 2023
thomasdax98
approved these changes
Nov 23, 2023
jamesricky
added a commit
that referenced
this pull request
Jan 9, 2024
Co-authored-by: Thomas Dax <thomas.dax@vivid-planet.com> Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.