Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsed menu hover effect #1240

Merged
merged 75 commits into from
Apr 22, 2024
Merged

Collapsed menu hover effect #1240

merged 75 commits into from
Apr 22, 2024

Conversation

jomunker
Copy link
Contributor

@jomunker jomunker commented Aug 29, 2023 •
edited by johnnyomair
Loading

This PR adds the hover functionality for the collapsed menu.

Screen recording

Screen.Recording.2023-10-05.at.12.45.58.mov

@thomasdax98 thomasdax98 changed the base branch from main to next August 30, 2023 06:50
@thomasdax98 thomasdax98 requested review from jamesricky and removed request for thomasdax98 August 31, 2023 07:33
@johnnyomair
Copy link
Collaborator

IMO review requests should only be requested once the PR is ready to review (not WIP:) 🙂

@jomunker jomunker changed the base branch from next to menu-subsubitems September 27, 2023 08:31
@jomunker jomunker changed the base branch from menu-subsubitems to next September 27, 2023 08:32
@jomunker jomunker changed the base branch from next to menu-subsubitems September 27, 2023 11:20
@jomunker jomunker force-pushed the collapsed-menu-hover-effect branch from e4e43ad to 36ccf11 Compare April 17, 2024 10:32
@jomunker jomunker requested a review from jamesricky April 17, 2024 10:34
@jomunker jomunker requested a review from thomasdax98 April 18, 2024 07:08
jamesricky
jamesricky reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jamesricky jamesricky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please compare your implementation to the design, this still doesn't look quite right (e.g. the item spacing and the submenu arrow)

Screenshot 2024-04-18 at 09 16 10

@jomunker jomunker requested a review from jamesricky April 18, 2024 09:59
@jomunker @jamesricky
refactor(CollapsibleItem): change target to currentTarget in handlePo…
c2ee930 
…poverClose function to avoid type casting

Co-authored-by: Ricky James Smith <jamesricky@me.com>
johnnyomair
johnnyomair approved these changes Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash this one for sure 😁

@thomasdax98 thomasdax98 removed their request for review April 22, 2024 08:24
@johnnyomair johnnyomair merged commit dc8bb6a into feature/menu-rework Apr 22, 2024
1 check passed
@johnnyomair johnnyomair deleted the collapsed-menu-hover-effect branch April 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasdax98 thomasdax98 thomasdax98 left review comments

@jamesricky jamesricky jamesricky approved these changes

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@jomunker jomunker

Labels
None yet
Projects
None yet
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jomunker @johnnyomair @jamesricky @thomasdax98