-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for menu subsubitems #1234
Conversation
fixup! feat(Menu): add MenuGroupSection component
|
Co-authored-by: Ricky James Smith <jamesricky@me.com>
874882e
to
a3cf811
Compare
47f7a52
to
985aebc
Compare
…pProps Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
# Conflicts: # packages/admin/admin/src/mui/menu/Item.tsx
I'll review this once #1233 has been merged. Setting as draft for now. |
@jomunker the base PR has been merged, please update this branch and solve conflicts so we can review it again, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add an example of this feature to the dev-stories?
Either in a new story or maybe in the existing menu-story: packages/admin/admin-stories/src/admin/mui/Menu.tsx
This would be very helpful for review and for future changes/debugging of this feature.
@jomunker the implementation seems to differ from the design:
Are these things already implemented in one of the follow-up PRs?
|
Seems like i fixed the design in the follow up PR. See the following screen recording. Sorry for the confusion with the follow up PRs. Screen.Recording.2024-02-29.at.10.21.42.mov |
depends on #1233
This PR adds support for menu subsubitems (third level items).
Screenshots