increase the cancel wait time between thread #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 seconds seems quite long. Can this be reduced to 2 or 3 seconds ? |
On our machine, the original timeout is insufficient, causing the USB gadget to close when attempting to cancel a file transfer. We've extended the timeout with additional redundancy to prevent this from happening. Signed-off-by: gujie <jie.gu@leica-geosystems.com.cn>
5446f8d to
a4a1cd3
Compare
Yeah, I tested. 1 second sometimes is not good in our machine. 2 seconds are good. I prefer 2.5 seconds because of adding some redundancy. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our machine, the original timeout is insufficient, causing the USB gadget to close when attempting to cancel a file transfer. We've extended the timeout with additional redundancy to prevent this from happening.