When unhealthy, do not shutdown the queryservice if the tablet's type is "worker". #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the database directly.
… is "worker". Otherwise, vtworker SplitClone would not succeed for larger datasets: When setting a source tablet to "worker", vtworker would get shut out from reading from it. Added integration test which verifies the correct behavior.
|
@alainjobart Can you please take over this review? Thanks! |
|
LGTM |
1 similar comment
|
LGTM |
michael-berlin
added a commit
that referenced
this pull request
Jul 17, 2015
When unhealthy, do not shutdown the queryservice if the tablet's type is "worker".
rsajwani
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 1, 2022
* feat: remove kv_store from vtorc codebase Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add import for side-effects for fixing tests Signed-off-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alainjobart @enisoc
@aaijazi FYI