Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTOrc Cleanup: Remove KV stores #10645

Merged
merged 3 commits into from
Jul 10, 2022
Merged

Conversation

GuptaManan100
Copy link
Member

Description

Orchestrator supports key-value stores for primary discovery which is documented here at https://github.com/openark/orchestrator/blob/master/docs/kv.md. Vitess has topo-server for this and VTOrc does not need a separate kv-store. This PR removes the VTOrc specific code to kv-stores and all its uses.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 7, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 merged commit 547c518 into vitessio:main Jul 10, 2022
@GuptaManan100 GuptaManan100 deleted the vtorc-cleanup branch July 10, 2022 11:58
rsajwani pushed a commit to planetscale/vitess that referenced this pull request Aug 1, 2022
* feat: remove kv_store from vtorc codebase

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: add import for side-effects for fixing tests

Signed-off-by: Manan Gupta <manan@planetscale.com>
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Aug 16, 2023
* feat: remove kv_store from vtorc codebase

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: add import for side-effects for fixing tests

Signed-off-by: Manan Gupta <manan@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTorc Vitess Orchestrator integration Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants