Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #72 - toArray issue IE11. Babel not working. #100

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Fixes #72 - toArray issue IE11. Babel not working. #100

merged 2 commits into from
Sep 19, 2019

Conversation

jasonex7
Copy link
Contributor

Fixes #72 - toArray issue IE11. Babel not working.

  • Use devDependencies @babel/runtime and @babel/plugin-transform-runtime to transform resulting output.
  • Configure babel only on rollup.config.js and not on .babelrc to apply to resulting output and not only files of this project.
  • Change to rollup-plugin-terser instead of rollup-plugin-babel-minify.

@jasonex7
Fixes visjs#72 - toArray issue IE11. Babel not working.
3cf2929 
- Use @babel/runtime and @babel/plugin-transform-runtime to transform resulting output.
- Configure babel only on rollup.config.js and not on .babelrc to apply to resulting output and not only files of this project.
@jasonex7 jasonex7 mentioned this pull request Sep 18, 2019
Closed
@mojoaxel mojoaxel requested a review from Thomaash September 18, 2019 09:44
mojoaxel
mojoaxel previously approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you so much!
I'm so happy if this is fixed!
LGTM, but @Thomaash should have a look, also!

Thomaash
Thomaash requested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be opening a PR which will solve all of these and many more issues later. Although since my effort to do it in Vis Network took 29 days and counting it may be a good idea to fix and merge this now to resolve at leas some of them.

rollup.config.js Show resolved Hide resolved
@jasonex7
Fixes visjs#72 - toArray issue IE11. Babel not working.
531691d 
- Restore .babelrc file because there are more things using Babel than Rollup.
- Configure rollup to exclude .babelrc files. Ref: https://github.com/rollup/rollup-plugin-babel#external-dependencies
Thomaash
Thomaash approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@Thomaash Thomaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yotamberk yotamberk merged commit 9ca14e7 into visjs:master Sep 19, 2019
@jasonex7 jasonex7 deleted the ie11 branch September 19, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomaash Thomaash Thomaash approved these changes

@yotamberk yotamberk yotamberk approved these changes

@mojoaxel mojoaxel Awaiting requested review from mojoaxel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toArray issue IE11. Babel not working.
4 participants
@jasonex7 @mojoaxel @yotamberk @Thomaash