Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toArray issue IE11. Babel not working. #72

Closed
frankdevryerold opened this issue Aug 30, 2019 · 6 comments · Fixed by #100
Closed

toArray issue IE11. Babel not working. #72

frankdevryerold opened this issue Aug 30, 2019 · 6 comments · Fixed by #100
Labels
bug Something isn't working
Milestone
v6

Comments

@frankdevryerold
Copy link

I'm getting the following error in IE11. I tried to convert it with babel but same error. Is this known and does someone have a fix? Cheers!

gantissue
@yotamberk
Copy link
Member

yotamberk commented Aug 31, 2019 •
edited
Loading

Can you supply a full example?
It seems that your this.items is not an object (I don;t think it's specifically a IE11 problem).

@mojoaxel mojoaxel added the bug Something isn't working label Aug 31, 2019
@mojoaxel mojoaxel added this to the v6 milestone Sep 1, 2019
@frankdevryerold
Copy link
Author

Can you supply a full example?
It seems that your this.items is not an object (I don;t think it's specifically a IE11 problem).

@yotamberk I think it is tho. I just checked the example pages of VIS and getting the same error as mine. https://visjs.github.io/vis-timeline/examples/timeline/basicUsage.html

@yotamberk
Copy link
Member

yotamberk commented Sep 7, 2019 •
edited
Loading

Eh... I guess you force me to download IE11... Fine... The things I do for you guys... 😝
UPDATE:
I'm getting a Object expected error in Range.js (18,30). Weird....

@melloware
Copy link
Contributor

Is it some kind of IE polyfill issue with the To.ToArray call?

@mojoaxel mojoaxel mentioned this issue Sep 15, 2019
Closed
@mojoaxel
Copy link
Member

This problems are caused by vis-util. (see visjs/vis-util#59)

jasonex7 added a commit to jasonex7/vis-timeline that referenced this issue Sep 18, 2019
@jasonex7
Fixes visjs#72 - toArray issue IE11. Babel not working.
3cf2929 
- Use @babel/runtime and @babel/plugin-transform-runtime to transform resulting output.
- Configure babel only on rollup.config.js and not on .babelrc to apply to resulting output and not only files of this project.
@jasonex7 jasonex7 mentioned this issue Sep 18, 2019
Merged
@jasonex7
Copy link
Contributor

I see problems in calls to Object.assign, Object.values, etc. Those functions are not present in IE11 so you can use babel/runtime to include those polyfills. I test PR #100 and it works on IE11 🎉

jasonex7 added a commit to jasonex7/vis-timeline that referenced this issue Sep 18, 2019
@jasonex7
Fixes visjs#72 - toArray issue IE11. Babel not working.
531691d 
- Restore .babelrc file because there are more things using Babel than Rollup.
- Configure rollup to exclude .babelrc files. Ref: https://github.com/rollup/rollup-plugin-babel#external-dependencies
yotamberk pushed a commit that referenced this issue Sep 19, 2019
@jasonex7 @yotamberk
Fixes #72 - toArray issue IE11. Babel not working. (#100)
9ca14e7 
* Fixes #72 - toArray issue IE11. Babel not working.
- Use @babel/runtime and @babel/plugin-transform-runtime to transform resulting output.
- Configure babel only on rollup.config.js and not on .babelrc to apply to resulting output and not only files of this project.

* Fixes #72 - toArray issue IE11. Babel not working.
- Restore .babelrc file because there are more things using Babel than Rollup.
- Configure rollup to exclude .babelrc files. Ref: https://github.com/rollup/rollup-plugin-babel#external-dependencies
@jasonex7 jasonex7 mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v6
Development

Successfully merging a pull request may close this issue.

Fixes #72 - toArray issue IE11. Babel not working. jasonex7/vis-timeline
5 participants
@mojoaxel @yotamberk @melloware @jasonex7 @frankdevryerold