[RSDK-9847] - Bump gortsplib dep #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexbabe
reviewed
Jan 29, 2025
| @@ -6,22 +6,22 @@ toolchain go1.23.2 | |||
|
|
|||
There was a problem hiding this comment.
Do reconfigures/reboot behavior look ok?
| @@ -202,7 +201,7 @@ func TestRTSPCameraPerformance(t *testing.T) { | |||
| timeoutCtx, timeoutCancel := context.WithTimeout(context.Background(), time.Second*10) | |||
| defer timeoutCancel() | |||
| config := resource.NewEmptyConfig(camera.Named("foo"), ModelAgnostic) | |||
| config.ConvertedAttributes = &Config{Address: "rtsp://" + h.s.RTSPAddress} | |||
| config.ConvertedAttributes = &Config{Address: "rtsp://" + h.s.RTSPAddress + "/"} | |||
There was a problem hiding this comment.
Did we confirm that this doesn't double append /?
| if !ok { | ||
| return | ||
| } | ||
| ntp := time.Now() | ||
| u, err := fp.ProcessRTPPacket(pkt, ntp, pts, true) | ||
| u, err := fp.ProcessRTPPacket(pkt, ntp, time.Duration(pts), true) |
There was a problem hiding this comment.
Is PTS not time since epoch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumping gortsplib to get latest improvements from h264/5 decoders. There seems to be some progress in improving fragmentation units here in the last few months.
The only deprecation change is moving from
PacketPTStoPacketPTS2.Tests