Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samus eater teleport #1908

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Samus eater teleport #1908

merged 3 commits into from
Jan 23, 2025

Conversation

blkerby
Copy link
Contributor

@blkerby blkerby commented Jan 22, 2025

This introduces

  • a new tech canSamusEaterTeleport
  • new entrance/exit conditions leaveWithSamusEaterTeleport and comeInWithSamusEaterTeleport
  • setups in Hellway and Alpha Power Bomb Room
  • applications in many rooms (covering all examples that I know of)

As usual, videos for all the new strats are on https://videos.maprando.com.

@blkerby blkerby added Model:Logic Element Involves adding a logical element. Can be a breaking change if modifying existing strats to use it. Logic:Tech Area:Many labels Jan 22, 2025
osse101
osse101 reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@osse101 osse101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
The normalized movements to touch the transition after 2 frames works well.

region/brinstar/pink/Big Pink.json Outdated
"entranceCondition": {
"comeInWithSamusEaterTeleport": {
"floorPositions": [],
"ceilingPositions": []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably shouldn't be empty

@osse101 osse101 merged commit 4919766 into vg-json-data:master Jan 23, 2025
1 check passed
@blkerby blkerby deleted the samus-eater-teleport branch February 4, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osse101 osse101 osse101 left review comments

Assignees
No one assigned
Labels
Area:Many Logic:Tech Model:Logic Element Involves adding a logical element. Can be a breaking change if modifying existing strats to use it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blkerby @osse101