-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change enemy farms to use partialRefill throughout #1702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should move things in a good direction. I gave some feedback, but I'm not expecting them to be incorporated; it can be merged as is.
@@ -479,7 +479,8 @@ | |||
"nodes": [1, 2], | |||
"mustStayPut": false | |||
}}, | |||
{"refill": ["Energy", "Super"]} | |||
{"partialRefill": {"type": "Energy", "limit": 100}}, | |||
{"partialRefill": {"type": "Super", "limit": 5}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if there is a way we could model the energy as only if youre close to full on supers.
{"refill": ["Missile", "Super"]} | ||
{"partialRefill": {"type": "Energy", "limit": 240}}, | ||
{"partialRefill": {"type": "Missile", "limit": 20}}, | ||
{"partialRefill": {"type": "Super", "limit": 4}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually it could be nice to model this differently - as number of killable enemies or something, and then the refill could take into account if the room is resettable and how much patience there is.
}}, | ||
"ScrewAttack", | ||
{"partialRefill": {"type": "Super", "limit": 4}}, | ||
{"partialRefill": {"type": "Energy", "limit": 80}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not a problem, but i wonder if this should have some sort of knowledge check on it. Without it, the player could still farm the skulterras and get the energy, so it is mostly about the Supers.
@@ -298,7 +298,9 @@ | |||
]} | |||
]}, | |||
"h_canUsePowerBombs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could eventually consider bombs or spring here
@@ -102,7 +103,30 @@ | |||
"nodes": [1], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be HiJump or Gravity, but then youll probably be able to just do the gravity variant
Co-authored-by: kjbranch <61815121+kjbranch@users.noreply.github.com>
The numbers are mostly arbitrary, but represent not spending an excessive amount of time reloading the room to farm.
Writing it this way would make it more dependent on the player estimating farm rates to know when farm thresholds are logical.
Every partialRefill location could spend more time farming than expected to refill more than the indicated numbers. CanBeXXXPatient could be added for more refill thresholds.